|
Post by alien750 on Oct 6, 2023 0:52:23 GMT -8
This doesn't seem to work for me. Here is the log:
11:52:13.543 8756 explorer.exe [WH] [local@classic-taskbar-fix-lite] [216:HookSymbols]: Couldn't resolve all symbols from cache 11:52:13.559 8756 explorer.exe [WH] [local@classic-taskbar-fix-lite] [221:HookSymbols]: Wh_FindFirstSymbol failed 11:52:13.559 8756 explorer.exe [WH] [local@classic-taskbar-fix-lite] [137:Wh_ModInit]: Failed to hook one or more function This is a symbols issue. Perhaps explorer cannot connect to the internet, or maybe your OS version doesn't have symbols available for it.
You can still download the symbols manually with PDB Downloader. Drop the resulting folder named explorer into C:\ProgramData\Windhawk\Engine\Symbols, and then restart the mod. Yeah, I've been using a firewall rule to block the internet access of explorer.exe. Disabling firewall still didn't work, so I tried PDB Downloader. But I'm not sure which DLL or executable to select in the list since selecting C:\WINDOWS\explorer.exe didn't download anything.
|
|
|
Post by betamaster on Oct 11, 2023 6:12:49 GMT -8
I can't get this mod to work right. What are "all the other classic theme mitigations"? (I've already enabled the mitigations in ExplorerPatcher, are there more?) Here is the log: 15:12:12.192 11588 explorer.exe [WH] [local@classic-taskbar-fix] [135:operator()]: Hooked 00007FF79AA92000: public: virtual long __cdecl CTaskBtnGroup::SetLocation(int,int,struct tagRECT const *) 15:12:12.192 11588 explorer.exe [WH] [local@classic-taskbar-fix] [135:operator()]: Hooked 00007FF79AA83EA0: private: void __cdecl CTaskBtnGroup::_DrawBar(struct HDC__ *,struct BUTTONRENDERINFO const &,struct BUTTONRENDERINFOSTATES const &) 15:12:12.192 11588 explorer.exe [WH] [local@classic-taskbar-fix] [135:operator()]: Hooked 00007FF79AA89628: void __cdecl GDIHelpers::FillRectARGB(struct HDC__ *,struct tagRECT const *,unsigned char,unsigned long,bool)
|
|
|
Post by yingying814 on Oct 13, 2023 21:51:32 GMT -8
Great work! Thank you very much. But, is there a way to change the taskbar colour? Now, my task bar is in light grey, but I would like to change it into 192,192,192
|
|
|
Post by betamaster on Oct 14, 2023 2:05:05 GMT -8
I can't get this mod to work right. What are "all the other classic theme mitigations"? (I've already enabled the mitigations in ExplorerPatcher, are there more?) Here is the log: 15:12:12.192 11588 explorer.exe [WH] [local@classic-taskbar-fix] [135:operator()]: Hooked 00007FF79AA92000: public: virtual long __cdecl CTaskBtnGroup::SetLocation(int,int,struct tagRECT const *) 15:12:12.192 11588 explorer.exe [WH] [local@classic-taskbar-fix] [135:operator()]: Hooked 00007FF79AA83EA0: private: void __cdecl CTaskBtnGroup::_DrawBar(struct HDC__ *,struct BUTTONRENDERINFO const &,struct BUTTONRENDERINFOSTATES const &) 15:12:12.192 11588 explorer.exe [WH] [local@classic-taskbar-fix] [135:operator()]: Hooked 00007FF79AA89628: void __cdecl GDIHelpers::FillRectARGB(struct HDC__ *,struct tagRECT const *,unsigned char,unsigned long,bool)
Fixed. If anyone else is having this problem, go into OpenShell settings and under the Taskbar tab, change Taskbar look to Opaque, and change Taskbar color to 000000.
|
|
AnyKey
Sophomore Member
Posts: 248
OS: Windows 10 Pro 22H2
Theme: XP Classic Theme
CPU: AMD Ryzen 7 3700X
RAM: 16 GB 1333 MHz DDR4
GPU: Nvidia Geforce RTX 2070 Super
|
Post by AnyKey on Oct 15, 2023 5:29:36 GMT -8
Any ways to make active task text bold? I know you want to suggest me to set caption text bold but Japanese classic color schemes are not so.
|
|
aubymori
Sophomore Member
π
π
π
π
π
Posts: 160
OS: Windows 10 IoT Enterprise LTSC 2021
Theme: Windows 10 Default
CPU: Intel Core i5-9300H
RAM: 8GB
GPU: Intel UHD Graphics 630 / NVIDIA GeForce GTX 1650
|
Post by aubymori on Oct 21, 2023 0:00:40 GMT -8
Any ways to make active task text bold? I know you want to suggest me to set caption text bold but Japanese classic color schemes are not so. Taskbar item font is controlled by ExplorerPatcher's DrawThemeTextEx hook. I tried hooking this in Windhawk myself, but unfortunately it just doesn't work with ExplorerPatcher's hook in place. I have submitted a pull request to the ExplorerPatcher repository to fix this, so hopefully it should appear in an update to ExplorerPatcher.
|
|
aubymori
Sophomore Member
π
π
π
π
π
Posts: 160
OS: Windows 10 IoT Enterprise LTSC 2021
Theme: Windows 10 Default
CPU: Intel Core i5-9300H
RAM: 8GB
GPU: Intel UHD Graphics 630 / NVIDIA GeForce GTX 1650
|
Post by aubymori on Oct 21, 2023 11:34:59 GMT -8
PR got merged :3
|
|
|
Post by anixx on Oct 22, 2023 0:00:45 GMT -8
Possibly you could consider making a pull request to the similar Windhawk mod, which is based on EP.
|
|
AnyKey
Sophomore Member
Posts: 248
OS: Windows 10 Pro 22H2
Theme: XP Classic Theme
CPU: AMD Ryzen 7 3700X
RAM: 16 GB 1333 MHz DDR4
GPU: Nvidia Geforce RTX 2070 Super
|
Post by AnyKey on Oct 22, 2023 2:00:11 GMT -8
Ah, great. Thank you for your work.
|
|
|
Post by OrthodoxWin32 on Oct 22, 2023 2:22:22 GMT -8
Possibly you could consider making a pull request to the similar Windhawk mod, which is based on EP. Here is the file : classic-theme-explorer.c (33.57 KB)
|
|
|
Post by anixx on Oct 22, 2023 4:25:18 GMT -8
Should be better merged upstream.
|
|
aubymori
Sophomore Member
π
π
π
π
π
Posts: 160
OS: Windows 10 IoT Enterprise LTSC 2021
Theme: Windows 10 Default
CPU: Intel Core i5-9300H
RAM: 8GB
GPU: Intel UHD Graphics 630 / NVIDIA GeForce GTX 1650
|
Post by aubymori on Oct 22, 2023 7:14:31 GMT -8
Possibly you could consider making a pull request to the similar Windhawk mod, which is based on EP. I went and reimplemented the entirety of the classic theme mitigations myself in Windhawk. The problem is that EP has a hook which is always active, but relies on classic theme mitigations being enabled in EP to actually work with classic theme. And again, the problem with that is that you can't hook functions that EP has already hookked for some reason.
|
|
|
Post by OrthodoxWin32 on Oct 22, 2023 7:49:46 GMT -8
Possibly you could consider making a pull request to the similar Windhawk mod, which is based on EP. I went and reimplemented the entirety of the classic theme mitigations myself in Windhawk. The problem is that EP has a hook which is always active, but relies on classic theme mitigations being enabled in EP to actually work with classic theme. And again, the problem with that is that you can't hook functions that EP has already hookked for some reason. For me the first Windhawks reimplementation work.
|
|
|
Post by nonameneeded on Oct 22, 2023 16:35:33 GMT -8
Is there also a working version of this thing? The windhawk compiler can't compile it (or whatever this thing does).
C:\ProgramData\Windhawk\EditorWorkspace\mod.wh.cpp:28:10: fatal error: 'windhawk_utils.h' file not found #include <windhawk_utils.h>
|
|
|
Post by ephemeralViolette on Oct 23, 2023 6:39:42 GMT -8
Is there also a working version of this thing? The windhawk compiler can't compile it (or whatever this thing does). C:\ProgramData\Windhawk\EditorWorkspace\mod.wh.cpp:28:10: fatal error: 'windhawk_utils.h' file not found #include <windhawk_utils.h> Are you running the latest version of Windhawk? This wasn't added until some later release.
|
|
|
Post by nonameneeded on Oct 23, 2023 17:18:38 GMT -8
Ok, now it seems to work, which is great!
As far as I can tell by now this is more or less the final step to make Windows look good again (as far as the classic theme is concerned).
All the other additional taskbar apps and taskbow wasn't really working nicely for me so thx a lot.
But I was wondering if there is a possibility to make a tiny little program (like an exe) file so one doesn't need to use Windhawk at all?
|
|
|
Post by anixx on Oct 24, 2023 0:19:25 GMT -8
You can delete the most of Windhawk if you do not need to change the mods anymore. Particularly, compiler and UI folders in Windhawk directory.
|
|
aldon
Freshman Member
Posts: 56
|
Post by aldon on Oct 27, 2023 4:36:46 GMT -8
Awesome! Thank you γͺγΌγγͺγΌ and anixx! But how to use it together with EP? I installed Windhawk, compiled script, turned it on, restarted explorer.exe and... nothing changed.
|
|
excel8
Freshman Member
Posts: 37
OS: Windows 10 22H2
|
Post by excel8 on Nov 21, 2023 17:16:06 GMT -8
It doesn't work for me, and I have classic theme enabled
I'm in Windows 10 22H2
|
|
|
Post by anixx on Nov 21, 2023 17:35:56 GMT -8
It doesn't work for me, and I have classic theme enabled
I'm in Windows 10 22H2
Patch OpenShell.
|
|