|
|
Post by travis on Aug 6, 2023 1:46:39 GMT -8
|
|
|
|
Post by TechSalt on Aug 6, 2023 2:26:44 GMT -8
Source code?
|
|
|
|
Post by anixx on Aug 6, 2023 4:50:46 GMT -8
I thought it used the system font anyway?
|
|
Souper
Freshman Member
Posts: 63
OS: Manjaro | Windows 10 (2021)
Theme: Placeholder | Aero / Luna
|
Post by Souper on Aug 6, 2023 11:47:47 GMT -8
you could probably open a pull request for this
also yeah given it supports windows 7 i would've expected it to already use the system font
|
|
|
|
Post by travis on Aug 6, 2023 13:34:23 GMT -8
I thought it used the system font anyway? The font was originally hardcoded to Tahoma. |
|
|
|
Post by anixx on Aug 6, 2023 21:12:58 GMT -8
I thought it used the system font anyway? The font was originally hardcoded to Tahoma. Ah, I see. I use Tahoma as system font anyway.
You should submit the changes to their github.
|
|
|
|
Post by anixx on Aug 6, 2023 21:14:25 GMT -8
What do you mean by "start button padding" by the way?
|
|
|
|
Post by OrthodoxWin32 on Aug 7, 2023 2:01:18 GMT -8
Hello travis, I manage to compile Open-Shell to full with AppVeyor, so I don't have to replace the DLL. If I have the source code of your modifications, I will be able to do it. On the other hand, I noticed differences in the positioning of the start button between the old patched versions (I was using version 4.4.170), the current version patched in the same way, and the current version with your improvements. Original version (4.4.170) with changes from Valinet :  The rendering is correct. Current version of Open-Shell, with modifications from Valinet (which I imported myself) :  The start button (and menu) is too far to the right, and the first icon is slightly too close to the start button. The start button is also too high. Current version of Open-Shell, with changes from Valinet's edits + changes from Travis :  The start button is again placed correctly (further to the left), but is still too high. Also, the first icon is far too close to the start button. |
|
|
|
Post by travis on Aug 7, 2023 13:29:49 GMT -8
Hello travis , I manage to compile Open-Shell to full with AppVeyor, so I don't have to replace the DLL. If I have the source code of your modifications, I will be able to do it. On the other hand, I noticed differences in the positioning of the start button between the old patched versions (I was using version 4.4.170), the current version patched in the same way, and the current version with your improvements. Original version (4.4.170) with changes from Valinet : View AttachmentThe rendering is correct. Current version of Open-Shell, with modifications from Valinet (which I imported myself) : View AttachmentThe start button (and menu) is too far to the right, and the first icon is slightly too close to the start button. The start button is also too high. Current version of Open-Shell, with changes from Valinet's edits + changes from Travis : View AttachmentThe start button is again placed correctly (further to the left), but is still too high. Also, the first icon is far too close to the start button. Here I attached StartButton.cpp which should be the only file that I have modified.
Attachments:StartButton.cpp (20.21 KB)
|
|
|
|
Post by OrthodoxWin32 on Aug 7, 2023 15:23:24 GMT -8
Here I attached StartButton.cpp which should be the only file that I have modified.
Thank you. |
|
|
|
Post by anixx on Nov 12, 2023 11:23:23 GMT -8
When I use this file, I get stack buffer overflow periodically. |
|
|
|
Post by anixx on Nov 12, 2023 16:10:23 GMT -8
Here I attached StartButton.cpp which should be the only file that I have modified.
Thank you. Do you have a successful buld which works now? |
|
|
|
Post by OrthodoxWin32 on Nov 13, 2023 15:08:08 GMT -8
Do you have a successful buld which works now? Yes, I replaced the DLL from my build of a recent version of Open-Shell, in which I had manually added the valinet changes (with a passable but problematic result, as I explain in a previous message). |
|
|
|
Post by anixx on Nov 14, 2023 13:07:31 GMT -8
Do you have a successful buld which works now? Yes, I replaced the DLL from my build of a recent version of Open-Shell, in which I had manually added the valinet changes (with a passable but problematic result, as I explain in a previous message). For me, the file by Travii brings periodic crashes. Can you share your patched file for OS 4.4.190? |
|
|
|
Post by OrthodoxWin32 on Nov 14, 2023 14:03:24 GMT -8
For me, the file by Travii brings periodic crashes. Can you share your patched file for OS 4.4.190? Yes, it is from version 4.4.190.
|
|
|
|
Post by anixx on Nov 14, 2023 14:23:15 GMT -8
Thank you very much. The look is good for me, I will wait to see if there are crashes.
|
|
|
|
Post by anixx on Nov 14, 2023 14:29:12 GMT -8
For me, the file by Travii brings periodic crashes. Can you share your patched file for OS 4.4.190? Yes, it is from version 4.4.190.
Will this link be permanent so to include it into the tutorial? |
|
|
|
Post by anixx on Nov 14, 2023 14:36:17 GMT -8
Well, indeed, there is a shift in the start button layout... It is shifted to the right. Did you use the patch by Travis?
|
|
|
|
Post by OrthodoxWin32 on Nov 14, 2023 15:18:26 GMT -8
Well, indeed, there is a shift in the start button layout... It is shifted to the right. Did you use the patch by Travis? I fixed this problem with the patch by Travis. However, the button unfortunately remains placed too low (compared to the old version of OpenShell). |
|
|
|
Post by anixx on Nov 14, 2023 15:48:26 GMT -8
Well, indeed, there is a shift in the start button layout... It is shifted to the right. Did you use the patch by Travis? I fixed this problem with the patch by Travis. However, the button unfortunately remains placed too low (compared to the old version of OpenShell). I use small taskbar height and this problem does not appear for me. I am only afraid of the crashes. |
|
