waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 9, 2024 15:04:40 GMT -8
The 1px gap above the vertical scrollbar and 1px gap to the left of the horizontal one is accurate to Win2000
To localize the text, you need to change the Folders Pane text option to 'default', if it still doesn't work after that then reload the mod because the localized string is loaded only when the mod is started. If this still doesn't work, then there will be a error entry in the log, or it means that you've indeed found a problem with my mod
As for the bottom of the treeview. All around the CNSCTree window there is a 3d etched border drawn (at the bottom it's shadow color above, and highlight below), and in your newest screen it looks like it's offset 1px up from where it's supposed to be. Looks to me like your Win95 explorer layout may be a factor in this problem. If you want to diagnose this, send me the window positions from WinSpy, relative to the client area, of the CNSCTree and it's parent window, the CtrlNotifySink. Both should be at 0, 0
Also, how did you get the gap between the items so small? Looks to me like you have the compact view enabled, and the tree item spacing set to -8.
|
|
Cynosphere
Freshman Member
Posts: 46 
OS: Windows 10 Home 22H2
Theme: Classic (Scheme: Amora Focus)
CPU: AMD Ryzen 7 3700X
RAM: 32 GB
GPU: AMD Radeon RX 7900 XT
|
Post by Cynosphere on Feb 9, 2024 15:21:21 GMT -8
I can also replicate the bottom of the list being off by 2px after updating to RC2
|
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 9, 2024 15:41:14 GMT -8
In coding RC2 I overlooked a single argument to SetWindowPos for the CtrlNotifySink, which led it to being moved up by whatever many pixels the organize bar takes, but not being scaled up by that many pixels on the Y axis, which is why you see this 2px gap only in RC2.
Usually with the organize bar being offset by -32px and the menu font being 8pt tahoma, the problem shouldn't be visible.
Try replacing the 4th argument to SetWindowPos at line 707 with rect.top and see if that fixes the problem for you.
I'll release RC3 once some more problems are adressed
|
|
|
|
Post by anixx on Feb 9, 2024 16:54:16 GMT -8
Also, how did you get the gap between the items so small? Looks to me like you have the compact view enabled, and the tree item spacing set to -8. The spacing in Classic Explorer (OpenShell) is set to -2.
I changed this to "default" and the caption is localized now, thanks!
|
|
|
|
Post by anixx on Feb 9, 2024 17:11:22 GMT -8
As for the bottom of the treeview. All around the CNSCTree window there is a 3d etched border drawn (at the bottom it's shadow color above, and highlight below), and in your newest screen it looks like it's offset 1px up from where it's supposed to be. Looks to me like your Win95 explorer layout may be a factor in this problem. If you want to diagnose this, send me the window positions from WinSpy, relative to the client area, of the CNSCTree and it's parent window, the CtrlNotifySink. Both should be at 0, 0
Pos Size
SysListVieew32 (2, 24) (180, 205)
NamespaceTreeConttrol (399, 42) (184, 210)
ControlNotifySink (32524, 32239) (184, 210)
DirectUIHWND (32524, 32239) (457, 211)
DUIViewWndClassName (32524, 32258) (457, 211)
ShellTabWindowClass (399, 42) (457, 250)
CabinetWClass (121, 174) (390, 298)
|
|
Cynosphere
Freshman Member
Posts: 46
OS: Windows 10 Home 22H2
Theme: Classic (Scheme: Amora Focus)
CPU: AMD Ryzen 7 3700X
RAM: 32 GB
GPU: AMD Radeon RX 7900 XT
|
Post by Cynosphere on Feb 9, 2024 17:31:40 GMT -8
Try replacing the 4th argument to SetWindowPos at line 707 with rect.top and see if that fixes the problem for you. It didn't fix the problem, but if I resize the sidebar it "fixes" itself, but only when resizing it to be wider and it jitters between the 2px gap every other pixel. |
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 10, 2024 3:32:43 GMT -8
Released RC3 now, should fix the problems for both of you.
If it doesn't, then I don't know what will.
|
|
|
|
Post by anixx on Feb 10, 2024 3:42:58 GMT -8
Released RC3 now, should fix the problems for both of you. If it doesn't, then I don't know what will. Looks good for me! The only issue remains is the slow scroll with mouse wheel, and it is definitely caused by the mod: with it disabled the wheel scrolling in tree view is faster.
The tooltip issue also remains, but it is the same without this mod active, so is not directly caused.
Check the positioning of th X button, it is a bit different from Win2000
|
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 10, 2024 14:19:07 GMT -8
RC4 coming your way.
Even though I can't reproduce your issue with the slower scrolling speed, I added a option to set the amount of items that are scrolled by at a single mouse wheel operation. This should fix your concern.
I fixed the tooltips too. This required me to draw a fully custom tooltip in a NM_CUSTOMDRAW handler. The results are not 100% perfect, but the difference compared to real Win2000 is so minute I can't be bothered to fix that.
I also moved the X button 1px to the left
I don't plan on adding any more features before the full release. If more problems are uncovered I will fix those, but that's it.
It's a pity I didn't get to add the menu entry. But the code was so broken, for reasons unknown, that fixing it would be a waste of time.
|
|
|
|
Post by anixx on Feb 10, 2024 14:57:45 GMT -8
RC4 coming your way. Even though I can't reproduce your issue with the slower scrolling speed, I added a option to set the amount of items that are scrolled by at a single mouse wheel operation. This should fix your concern. I fixed the tooltips too. This required me to draw a fully custom tooltip in a NM_CUSTOMDRAW handler. The results are not 100% perfect, but the difference compared to real Win2000 is so minute I can't be bothered to fix that. I also moved the X button 1px to the left I did not mean it should be moved to the left, I think, horizontally it was placed correctly, but it it shifted to the top. |
|
Cynosphere
Freshman Member
Posts: 46
OS: Windows 10 Home 22H2
Theme: Classic (Scheme: Amora Focus)
CPU: AMD Ryzen 7 3700X
RAM: 32 GB
GPU: AMD Radeon RX 7900 XT
|
Post by Cynosphere on Feb 10, 2024 18:58:23 GMT -8
The instability fix seems to prevent it from making any changes after Explorer is restarted until the mod is disabled and re-enabled
|
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 11, 2024 7:00:05 GMT -8
The instability fix seems to prevent it from making any changes after Explorer is restarted until the mod is disabled and re-enabled Do you mean that after a explorer restart, the mod has no effect anymore? What is in the mod log after explorer restart? There should be messages that the mod has initialized successfully. After the reliability fix, the mod completely depends on symbol hooking, which is less reliable than just hooking a normal function. I am 99% sure that the problem was caused by a conflict with ExplorerPatcher, and my instability fix is just a circumvention. I did not mean it should be moved to the left, I think, horizontally it was placed correctly, but it it shifted to the top. I've compared it to real Win2000, both using the windows standard theme, and it looks perfect pixel to pixel for me. Anyways, I won't change this again, because it's a very minor detail and it's impossible to support every theme/font combination to be pixel perfect. The tooltip is also 1 or 2 px off compared to the real one. The folder band is scaled accurately only when the menu font is Tahoma and it's size is 8-11, any other combination introduces innacuracies, more noticeable as the font difference grows. Unfortunately I can't support every font/size combination, and have it look correctly on every explorer configuration, that would be 5000 lines of edge cases.
If you want to change the location of the button, you need to modify the part in WM_PAINT where the variable rect is assigned values from origTop, origRight etc variables 4 times in a row. This occurs twice in WM_PAINT. You also need to modify the rect calculations in the handlers for WM_MOUSEMOVE, WM_LBUTTONDOWN, WM_MOUSELEAVE and WM_LBUTTONUP.
I'm setting my eyes on future endeavours. I am planning to make a mod to fix the ugly toolbar horizontal resize gripper, and maybe a separate mod NT4 Explorer that will use parts of the code from this mod.
|
|
clara
Sophomore Member
Posts: 118
|
Post by clara on Feb 11, 2024 12:39:17 GMT -8
I'm not sure if you still accept bug reports considering the last post, but i have noticed a tearing issue on tree items while scrolling. It gets worse the more items are displayed (captured with OBS).
Seems to be an issue from one of recent updates, i didn't keep any backups of previous versions, but i tried cynosphere's code from this thread and it does not have that exact issue, which confirms my memory of previous versions.
Changing scrolling settings has no effect on this issue.
|
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 11, 2024 13:03:49 GMT -8
Shit, I could swear I've seen this too, but thought it must be some drunk delusions again. Now I changed the code to use a different approach, try it now
I also removed 1 redundand function I somehow left in the RC4 release.
|
|
clara
Sophomore Member
Posts: 118
|
Post by clara on Feb 11, 2024 13:30:34 GMT -8
Shit, I could swear I've seen this too, but thought it must be some drunk delusions again. Now I changed the code to use a different approach, try it now Tried that. Sorry, the issue persists. |
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 11, 2024 14:15:39 GMT -8
I'm debating on removing the scroll option. Until some 15 minutes ago I didn't know that windows actually has a option to set the amount of items scrolled by at a time. I had it set to 3 all that time, but for some retarded reason it scrolled by only one at a time in the treeview, with my mod or without. When I set it to 4, it scrolls by 2 items. But in other native treeview controls, such as in regedit, it does scroll by the correct amount. On the other hand on windows 11 it works the way it's intended, and my naive scrolling speed up implementation led to the treeview reaching escape velocity when scrolled. This, and the graphical glitches makes me want to remove that feature.
|
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 19, 2024 7:27:30 GMT -8
Mod is now released in the offical WH repository.
I removed the scrolling speed option because it was buggy, and because I couldn't reproduce the issue it was meant to address anyways. I've also changed the way classic tooltips are restored, it's now much simpler, turns out no custom drawing was needed to accomplish this.
|
|
|
|
Post by anixx on Feb 19, 2024 7:41:13 GMT -8
Works well here. The tooltips now are of correct color. Looks great!
Consider adding a screenshot to the mod readme.
The X button is still too high by 1px.
There is some dotted line discontinuity in the last element:
|
|
waldemar21214
Freshman Member
Posts: 94
OS: Windows 10
Theme: Classic
CPU: i5-12400f
RAM: 16 GB DDR4 3600mhz
GPU: PNY 3060TI
|
Post by waldemar21214 on Feb 19, 2024 9:35:42 GMT -8
Unfortunately, it seems that the exact location of the X button is influenced by some unknown factors, propably related to the system locale. For me, the location is 100% accurate, so I won't change it in the release. I may add a preprocessor define that will allow to easily modify the exact position, or maybe even 2 settings for X and Y offsets.
The graphical problem you're experiencing is harder for me to diagnose because my investigation of the treeview item sizes yields contradicting information on several windows versions. Let's assert that the correct distance between the +/- buttons is 7 pixels: 3 shadow/highlight pixels, 4 background pixels, such as in your screenshot. You've stated that your tree item spacing is -2 in openshell settings, and you're on Win11 21H2. Then again, I'm on Win10 22H2, my tree item spacing is set to -2 too, and I have 9 pixels inbetween: 4 shadow, 5 background. And on a Win11 23H2 virtual machine, I have the tree item spacing set to -16 (or -6 and compact view enabled in folder settings), and the gap is 7 pixels as it is in your screenshot, but a additional 1 dot is drawn at the bottom, so the gap appears smaller.
It shouldn't be too hard to fix the gap, but I tried to get the distance to be 7px on my main install, and I'm unable to, so it's hard to diagnose. I tried adding TVS_NONEVENHEIGHT style to the treeview and setting the spacing to -3, but then the distance decreases too much.
I need to find a way to ensure 7px distance on all versions, then I'll be able to remove all the graphical issues with the lines.
|
|
|
|
Post by anixx on Feb 19, 2024 10:06:46 GMT -8
On screenshot by @clara the X button also looks too high.
|
|
