mmtrt
New Member
Posts: 12 
|
Post by mmtrt on Mar 7, 2017 11:55:30 GMT -8
Spitfire_x86 _x86 all is good I was using 98 Plus cpl cause that issue anyway earlier I was asking about this issue  Thats on small 10 explorer is set to.EDIT: its fixed my bad not used newer script on OP all is good now.  EDIT2: Nope I've tried classicthemeA.exe in this when explorer window is not theme start script gap is fixed if I restart explorer then launch script the gap comes back, also tried installed classictheme.exe gap is there which is really annoying :/
|
|
|
|
Post by anixx on Mar 7, 2017 14:16:13 GMT -8
MAJOR UPDATE: I've re-compiled the ROS explorer!  List of changes: - Removed desktop switcher and ROS-specific buttons
- Removed ROS volume tray icon (use my script for a working Win7-style volume control)
- Fixed position of the clock (it was 2px too high)
- Set the minimal width of Quick Launch to 0px so you can hide it completely
I've attached the executable to the original post and slightly updated my script.
You can code the Start button into it then. Can you please share the source code as well then? Maybe also submit the clock patch to ROS? |
|
|
|
Post by anixx on Mar 7, 2017 14:23:06 GMT -8
How do you start ROS explorer in taskbar mode by the way?
|
|
|
|
Post by anixx on Mar 7, 2017 14:25:32 GMT -8
...and this seems to be the OLD Reactos explorer. What about the new one which was written from scratch?
|
|
|
|
Post by Spitfire_x86 on Mar 8, 2017 0:15:08 GMT -8
I use '-desktop' parameter, but I'm going to modify it to always start in shell mode.
The new ROS Explorer is almost identical to WinXP explorer and it has many disadvantages. You have to start it in compatibility mode, you can't start it as shell alongside Win10 explorer and most tray icons won't appear.
I will probably change the clock on old explorer to clock from new explorer because it's still 1px off.
Start button is more difficult because it's supposed to open Classic Shell start menu. Right now I'm simulating Win key press with AHK. I'm not sure if it's possible to code it into the ROS explorer easily.
Edit: The clock position is correct on ReactOS, the problem occurs only on Win10... Maybe it's a font problem or something similar.
|
|
|
|
Post by Spitfire_x86 on Mar 8, 2017 2:47:15 GMT -8
mmtrt Do you have the "Use small taskbar buttons" option in Settings turned on? If not, switch it on and then add any toolbar to Win10 explorer.
|
|
mmtrt
New Member
Posts: 12
|
Post by mmtrt on Mar 8, 2017 5:08:51 GMT -8
mmtrt Do you have the "Use small taskbar buttons" option in Settings turned on? If not, switch it on and then add any toolbar to Win10 explorer. Thanks for the tip worked as expected and actually I had two toolbars enabled the one caused issue was netspeed monitor so disabled it voila everything is perfect.  I'm only missing toolbar support in ros old explorer well newer one has this. |
|
|
|
Post by Spitfire_x86 on Mar 8, 2017 6:41:05 GMT -8
Adding toolbars in the source code is actually easy, but making them toggleable is not. I have an idea that I'm gonna try later.
|
|
|
|
Post by anixx on Mar 8, 2017 8:06:39 GMT -8
The new ROS Explorer is almost identical to WinXP explorer and it has many disadvantages. You have to start it in compatibility mode, you can't start it as shell alongside Win10 explorer and most tray icons won't appear. I hope Splitwirez will share his method of starting Vista Explorer on W10 in taskbar mode. |
|
|
|
Post by Spitfire_x86 on Mar 11, 2017 5:29:27 GMT -8
New version of the script and ROS Explorer is available - details in the original post.
|
|
|
|
Post by R.O.B. on Mar 13, 2017 15:50:11 GMT -8
I'm sorry, I meant to post about this sooner. But this is very cool! This makes Windows 10 much more usable with the classic theme. Great work, Spitfire_x86!
I do have a few suggestions and notes (including a few bugs I found):
Start Button/Menu
-Any chance this will ever use a more "native" start button? What I mean by this is a start button that's rendered by GDI and that would completely follow system fonts/colors. Perhaps a logo could be loaded either from a resource-only DLL file, or even just a file specified by the user.
-Maybe it would be good to still provide options for a custom start button if the user really wants it (like with visual styles). Alternatively, what about custom Classic Shell start buttons?
-The start button doesn’t quite behave as it should. For example, in Windows you don’t have to click exactly on the start button to open the menu; clicking in the very bottom left would open the menu, as well as move the mouse to the bottom-left corner of the start button.
-Opening the start menu with the Windows key does not change the button to its “pressed” state. Also, the native Windows start menu doesn’t keep the pressed button state (at least on Windows 7).
-How about a “Click here to begin” tooltip?
Taskbar
-Any chance the notification area could behave a bit more like Windows 7? Mainly, with options to always show all icons that are actually functional.
-What about some improved taskbar settings that are closer to XP/Vista? Also, does running XP/Vista's explorer.exe in place of explorer_old.exe resolve this issue?
-How about an option to show seconds in the tray clock?
-Will the tray clock ever be able to use ClearType fonts? Also, will it ever use the system fonts?
Other
-Restarting explorer with this can be kind of a pain. This actually isn't that big an issue, as you should be able to create a batch file to do all the work for you.
-And finally, do you have any plans on making this open source?
Anyways, no pressure if you have issues implementing any of these features. These are just a couple of thoughts I had that I thought I’d share. Once again, great work so far! I look forward to future improvements with this!
|
|
|
|
Post by Spitfire_x86 on Mar 14, 2017 13:09:33 GMT -8
R.O.B. I'm working on this right now, but forcing AHK gui button to stay in pressed state and adding an icon to it is more complicated than just using a graphic button and doesn't work that well. For now you have to crop and split the graphic into two buttons manually because I can't find any reliable method of displaying only part of PNG file with AHK. ROS taskbar has window edges, I can't really expand the button to the corner if it's a child window. There is a workaround, but it involves executing AHK code that checks the cursor position every time the left mouse button is pressed  Just fixed it, I'll upload the updated version in a minute. For some reason I can't get the AHK tooltips to work. I don't understand. You can configure tray in ROS taskbar settings, and set which icons you want to see. If you mean Win10 icons (power, volume, network, defender) that show up on ROS tray but don't work, AFAIK you can't disable them completely (maybe in registry?), because ROS taskbar does not obey the Win10 'turn system icons on or off' setting. You can't start both Win10 explorer and Vista/XP explorer as shell at the same time. This is probably the most complicated thing of all  The ROS Explorer way of displaying clock is for some reason super complicated and I have no idea how to fix it. If you mean the modified ROS explorer code, then yes. It's mostly untouched, I just commented out some stuff.
|
|
|
|
Post by R.O.B. on Mar 14, 2017 14:18:33 GMT -8
Yeah, I meant the ROS Explorer's source code. Glad to hear that you're planning on making it open source, even if the changes you made to it are very small.  For the Classic Shell buttons, I was thinking more along the lines of its "Classic Start Button" option (since this already uses PNGs, lol). But if you're working on one with AHK, then this isn't really a big deal anyway. I look forward to seeing what you can come up with. For the notification area, I'm not talking about the native Windows 10 icons (like Network, Volume, etc.) as there are alternatives to most of those, one of which you even provide (I actually never expected to work, as they are designed specifically to hook with Windows 10's explorer.exe). I was more referring to the "Hide inactive icons" behavior. Disabling this with the ROS Explorer doesn't seem to change anything. One other thing to note is the taskbar doesn't seem to "lock" either (even though it can't seem to be moved). But I'm pretty sure this is a problem with the latest ReactOS build, so I'm not exactly holding out for a fix for this anytime soon (especially since this is based on explorer_old.exe, so even if the ReactOS Team were to fix this behavior, it would probably take a lot of work to get the code from the new explorer.exe to work with explorer_old). Also, I must have misread the thing about older versions of explorer.exe from Windows. My mistake. I realize this is still a work in progress, but I just thought I'd mention a few things that I think would be good. |
|
|
|
Post by anixx on Mar 14, 2017 22:18:47 GMT -8
You may try VBScript instead of AHK.
|
|
|
|
Post by mc4tnt on Mar 16, 2017 17:12:20 GMT -8
Hey, I came here just for asking if its doable, implementing WinXP taskbar style (Already done with Classic Shell (button+taskbar layout)) but with this ReacOS explorer, wondering if its possible to mimic it? VirusTotal's found 1 (Qihoo-360) as (HEUR/QVM20.1.0000.Malware.Gen), I guess this is harmless^^ virustotal.com/fr/file/99d319b6d309c28d47dc07a14d0f21743e573f054602b9fc6a1da69e1167ba57/analysis/1489713376/EDIT: Is there a way to invert the way how tray icons are loaded? Usually they pop at the left side rather than right side. Remembers myself which Windows 2K did it, later in WxP they pop at the left side (sorry my english sucks so I don't know the correct words/term) EDIT2: I have found this image you've posted on thinkpads forum: storage1.static.itmages.ru/i/16/0220/h_1455944484_5963990_de9f4c8b12.png, but it doesn't match the taskbar I tried on W7 (VM). Was another taskbar you used (explorer.exe variant?) or its ReactOS? |
|
|
|
Post by Spitfire_x86 on Mar 17, 2017 5:59:13 GMT -8
mc4tnt that screenshot is from Windows 8.1, for now it's impossible to make Win10 look exactly like that.
|
|
|
|
Post by mc4tnt on Mar 18, 2017 4:06:30 GMT -8
mc4tnt that screenshot is from Windows 8.1, for now it's impossible to make Win10 look exactly like that. So like its not possible to have the same notification area like in your screens on thinkpads forums? I mean "no" classic theme, but same systray behiavour (like in XP when you load a program)... Or else idk how to remove or resize icon spacing but keeping my custom startbutton and taskbar layout from Classic Shell on W10 (XP style but without the aqua color where systray icons are) I mean, that one (Currently W7, same for W10)  to  is possible? (Without the ENG thing) I don't even know if with AHK can edit icon spacing, I tried Zero dump, couldn't find how to change that :x Also, thanks for your reply^^ |
|
|
|
Post by anixx on Mar 18, 2017 12:05:21 GMT -8
mc4tnt that screenshot is from Windows 8.1, for now it's impossible to make Win10 look exactly like that. So like its not possible to have the same notification area like in your screens on thinkpads forums? I mean "no" classic theme, but same systray behiavour (like in XP when you load a program)... Or else idk how to remove or resize icon spacing but keeping my custom startbutton and taskbar layout from Classic Shell on W10 (XP style but without the aqua color where systray icons are) This is my screenshot. The icons spacing reduction is done using 7+ Taskbar Tweaker, using its "advanced options" (those accessible only via registry, not the dialog). It also is capable of removing the "show desktop" button from the right end of the taskbar. |
|
|
|
Post by Spitfire_x86 on Mar 18, 2017 12:05:43 GMT -8
mc4tnt What do you exactly mean? Notification area in ROS Explorer is similar to the XP tray. If you mean the icon spacing on Win10 or Win7 tray, I'm not sure how to edit it (maybe registry?) I've never really noticed that ROS explorer displays new icons on the wrong side. I don't think it's possible to change that.
|
|
|
|
Post by anixx on Mar 18, 2017 12:14:27 GMT -8
This parameter set to 2 makes the horizontal icon padding in tray the same as under Win95-XP:  It also allows to make the taskbar context menu to look like this:  |
|
